ekalda commented on PR #11335: URL: https://github.com/apache/tvm/pull/11335#issuecomment-1129071405
Thanks for the review @lhutton1! There isn't a simple way to test it since the channels will be passed to the get_valid_block_configs and the channels value will factor into the cycle counts of all the valid block configs and we can't determine the value of channels from a chosen block config. In case of conv2d, the channels have an effect on the estimated cycle counts, so I added a test that checks the cycle count against a known good value (it is indeed radically different pre and post fix). In case of depthwise and pooling, when I look get_valid_block_configs more closely, it doesn't actually use the ifm_channels value for anything, so passing a wrong value wasn't really a problem :D I think it would be good to still pass the correct value as we might need it in the future. I have checked from the debugger that we indeed pass the correct values, I hope that is alright for the time being :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
