mdwelsh commented on code in PR #8725:
URL: https://github.com/apache/tvm/pull/8725#discussion_r875253237
##########
rust/tvm-rt/src/object/object_ptr.rs:
##########
@@ -98,6 +103,18 @@ impl Object {
}
}
+ fn get_type_key(&self) -> String {
+ let mut cstring: *mut c_char = std::ptr::null_mut();
+ unsafe {
Review Comment:
Use of `unsafe` in Rust code is potentially dangerous and can lead to
crashes and memory corruption.
Please consider removing `unsafe`. Reviewers should inspect this code
carefully.
For more information about this comment, see
https://fixie.ai/comment/6abf0089a.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
