mdwelsh commented on code in PR #6741:
URL: https://github.com/apache/tvm/pull/6741#discussion_r875267378
##########
rust/tvm-rt/src/array.rs:
##########
@@ -118,6 +125,12 @@ impl<T: IsObjectRef> IntoIterator for Array<T> {
}
}
+impl<T: IsObjectRef> FromIterator<T> for Array<T> {
+ fn from_iter<I: IntoIterator<Item = T>>(iter: I) -> Self {
+ Array::from_vec(iter.into_iter().collect()).unwrap()
Review Comment:
Inconsistency: `FromIterator::from_iter()` is implemented elsewhere using
```
Array::from_vec(iter)
```
See the following similar code:
* array.rs:92
* graph_mod.rs:139
* graph_mod.rs:151
For more information about this comment, see
https://fixie.ai/comment/55732b1c0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
