Lunderberg commented on code in PR #11304:
URL: https://github.com/apache/tvm/pull/11304#discussion_r876055233
##########
tests/scripts/ci.py:
##########
@@ -195,6 +195,8 @@ def docker(name: str, image: str, scripts: List[str], env:
Dict[str, str], inter
command.append("-t")
scripts = ["interact() {", " bash", "}", "trap interact 0", ""] +
scripts
+ command.append("--net=host")
Review Comment:
Hmm. My goal with #8670 was to maintain identical behavior to before the
refactor. I kept the `--net=host` argument disable by default, but
conditionally add it back in for interactive sessions whose command is `bash`
with no additional arguments. Let me check to see if that behavior has drifted
since then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
