areusch commented on code in PR #11349:
URL: https://github.com/apache/tvm/pull/11349#discussion_r876120066
##########
jenkins/macros.j2:
##########
@@ -89,3 +89,33 @@
}
},
{% endmacro %}
+
+{% macro upload_artifacts(tag, filenames, folders=[]) %}
Review Comment:
i think in Python we would avoid kwarg with an empty list initializer (e.g.
`folders=None`), possible to do that here? i think that amounts to `for folder
in (folders or [])`
##########
jenkins/macros.j2:
##########
@@ -89,3 +89,33 @@
}
},
{% endmacro %}
+
+{% macro upload_artifacts(tag, filenames, folders=[]) %}
Review Comment:
can we still print the the md5?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
