AndrewZhaoLuo commented on code in PR #10216:
URL: https://github.com/apache/tvm/pull/10216#discussion_r876336487


##########
tests/python/relay/test_op_qnn_dense.py:
##########
@@ -237,6 +246,20 @@ def test_qnn_dense_with_bias():
         qnn_dense_driver(int32_output_with_bias_params)
 
 
+def test_qnn_dense_without_bias_with_3d_input():

Review Comment:
   Yeah, so the reason the test fails is because input shape is [1, 2, 10] and 
kernel shape is [3, 10] and these cannot broadcast (to be honest im not sure 
the semantics behind dense). Double check if the semantics behind the intention 
are correct.
   
   Personally, I think these tests are actually unrelated to the main change so 
I'm fine just cutting this out if you want.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to