SebastianBoblestETAS commented on code in PR #11334:
URL: https://github.com/apache/tvm/pull/11334#discussion_r876658319
##########
tests/python/relay/test_pipeline_executor.py:
##########
@@ -73,7 +71,7 @@ def merge_constant_expr(constant_expr, expr):
)
def _recursion(anf, pipeline_mods, split_conf, constant_expr):
- # Enumrate all operators of compute graph, then split the compute
graph into a group of
+ # Enumurate all operators of compute graph, then split the compute
graph into a group of
Review Comment:
```suggestion
# Enumerate all operators of compute graph, then split the compute
graph into a group of
```
##########
tests/python/relay/test_pipeline_executor.py:
##########
@@ -123,13 +125,13 @@ def _recursion(anf, pipeline_mods, split_conf,
constant_expr):
)
snode_dep.pop()
dep_vars = get_dep_var(snode_dep)
- # When the nodes of current subgraph are the depedency
node of other
+ # When the nodes of the current subgraph are the
depedency node of another
# subgraph, we need to set them as the output of
current subgraph.
body = relay.Tuple(dep_vars) if len(dep_vars) > 1 else
anf.var
- # when current subgraph use previous subgraph constant,
- # such constant may become free varaible due to the
constant
- # not exist, merge the previous constant with current
subgraph
- # to avoid such issue.
+ # when the operator of current subgraph uses previous
subgraph constant
+ # as the argument of a "relay.expr.call", such
constant may become a free
+ # varaible if the constant does not exist in the
current subgraph.
Review Comment:
```suggestion
# variable if the constant does not exist in the
current subgraph.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
