Lunderberg commented on PR #11373: URL: https://github.com/apache/tvm/pull/11373#issuecomment-1132096985
Good point, and I hadn't considered Nan. Looking through other operators, it looks like there are existing simplifications that would also change `NaN` propagation (e.g. [Simplifying `x==y || x!=y`](https://github.com/apache/tvm/blob/main/src/arith/rewrite_simplify.cc#L1553) to true, or [simplifying `!(x <= y)` to `y < x`](https://github.com/apache/tvm/blob/main/src/arith/rewrite_simplify.cc#L1485)), so it wouldn't break any existing guarantees. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
