tqchen commented on PR #71:
URL: https://github.com/apache/tvm-rfcs/pull/71#issuecomment-1133026002
Thanks folks for discussions. I think they summarizes to the following points
- Q0: Subfield grouping (e.g. features) or simply leave as top-level attrs
- Q1: Folder structure: `target/preprocessors/cuda.cc` vs
`target/cuda/cuda_preprocessor.cc`
- Note that code-reuse is less likely going to be an issue as there can
be common includes among sub-folder structures.
- Q2: How to reconcile attributes specified already for (part of) subfield
group, `llvm` can use `mattr` to specify the feature necessary. What happens to
CUDA(e.g. we proposing to group hw related limitations to features), and how
can we specify some of the fields(under the proposal will go into a subfield
`feature`) during tag registration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
