mbs-octoml commented on PR #10963: URL: https://github.com/apache/tvm/pull/10963#issuecomment-1133417421
Shoot, I've stepped on this in #11382, sorry about that. In that PR I clearly distinguish the 'multi-target' APIs from the 'single-target' APIs. Everything in the tuning world needs to use the 'single-target' APIs. I'd be fine with an assert isinstance(target, tvm.target.Target) if we know all codepaths respect that. But I think targets transition from Target to str and back quite a bit in the tuning world, so I'd suggest just letting the canonicalization deal with it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
