areusch commented on PR #11384: URL: https://github.com/apache/tvm/pull/11384#issuecomment-1135005073
regarding overloading `ssize_t` vs adding `tvm_ssize_t`, my main preference here is around when we do this in a public-facing header file (in that case I pushed for `tvm_ssize_t` to avoid stepping on system types outside tvm's purview. for an internal header in `src/` i don't have a strong reason to care right now. if others do, i'm happy to go with their preference, though prefer such decisions to be rooted in more than just personal preference. this PR reverts to what we were using before, so i'm good with merging it and re-addressing later on if it becomes an issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
