tkonolige commented on PR #11391: URL: https://github.com/apache/tvm/pull/11391#issuecomment-1137574311
@vvchernov I see that you are still changing the semantics of `FromExternalDLTensor`. `FromExternalDLTensor(DLTensor* dl_tensor, const Device& dst_dev)` will copy if alignment is wrong, but `FromExternalDLTensor(const DLTensor& dl_tensor)` will throw an error if the alignment is wrong. I think this is pretty confusing as they both have the same name. Can you make `FromExternalDLTensor(DLTensor* dl_tensor, const Device& dst_dev)` fail if alignment is wrong and instead move the copying logic into the VM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
