areusch commented on code in PR #11362:
URL: https://github.com/apache/tvm/pull/11362#discussion_r883021622
##########
tests/scripts/task_python_microtvm.sh:
##########
@@ -28,6 +28,7 @@ make cython3
run_pytest ctypes python-microtvm-zephyr-qemu_x86 tests/micro/zephyr
--zephyr-board=qemu_x86
run_pytest ctypes python-microtvm-zephyr-qemu_riscv32 tests/micro/zephyr
--zephyr-board=qemu_riscv32
run_pytest ctypes python-microtvm-zephyr-qemu_riscv64 tests/micro/zephyr
--zephyr-board=qemu_riscv64
+run_pytest ctypes python-microtvm-zephyr-mps2_an521 tests/micro/zephyr
--zephyr-board=mps2_an521
Review Comment:
oh oops, ignore. it's okay since your one test is build-only.
##########
apps/microtvm/zephyr/template_project/microtvm_api_server.py:
##########
@@ -70,6 +69,8 @@
ZEPHYR_BASE = os.getenv("ZEPHYR_BASE")
+CMSIS_PATH = os.getenv("CMSIS_PATH")
Review Comment:
i think it might be good to avoid hidden env variable dependencies. they can
be hard to track down. what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
