supersat commented on code in PR #11476:
URL: https://github.com/apache/tvm/pull/11476#discussion_r883096664


##########
python/tvm/contrib/hexagon/build.py:
##########
@@ -472,6 +477,15 @@ def _cleanup_directory(self):
         # Remove workspace directory on remote target
         subprocess.Popen(self._adb_device_sub_cmd + ["shell", f"rm -rf 
{self._workspace}"])
 
+    def _copy_artifacts_to_host(self):
+        # Copy generated artifacts from device to host
+        if self._host_workspace:
+            for file in ["tvm_rpc_android.farf", "tvm_rpc_android.log"]:

Review Comment:
   If the intention is to pull of the debug output from Hexagon, you'll likely 
need to run logcat in parallel, possibly filtering out extraneous messages from 
the rest of the system.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to