mhyang-pllab commented on PR #11488: URL: https://github.com/apache/tvm/pull/11488#issuecomment-1140177302
@echuraev thanks for your kindly reply. The purpose of this PR is to fix the falling test_opencl_ternary_expression and try to keep the compatibility with your accurate float4 typecasting case. You could manually invoke this test then it would fall without this PR. The test is currently failing with the environment ci_gpu image due to the select function signature causing ambiguous codegen. I don't why the test suite was passed the CI. The codegen problem is also happened in the real-world models. And I don't know if we should support khr_fp64 and khr_fp16 here. If not so, the current tests are enough to cover the problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
