masahi commented on code in PR #11341: URL: https://github.com/apache/tvm/pull/11341#discussion_r884488053
########## python/tvm/topi/x86/injective.py: ########## @@ -17,20 +17,20 @@ # pylint: disable=invalid-name """x86 declaration and schedules.""" from tvm import te +from tvm.topi import tag from tvm.tir import IntImm +from tvm.topi.generic.injective import schedule_injective_from_existing from ..utils import is_empty_shape -def schedule_injective_from_existing(sch, out): +def schedule_injective_from_existing_ref(sch, out): Review Comment: I don't know what that error means, but you shouldn't be making this change anyway. If the old `schedule_injective_from_existing` is used by other places, this change will make a different `schedule_injective_from_existing` (in `tvm.topi.generic.injective`) instead. One you cannot use the old `schedule_injective_from_existing` at L150? And since `tvm.topi.generic.injective.schedule_injective_from_existing` is just a one line schedule, https://github.com/apache/tvm/blob/813136401a11a49d6c15e6013c34dd822a5c4ff6/python/tvm/topi/generic/injective.py#L40 you can directly copy that in your concat schedule, to avoid importing and the name conflict issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
