crazydemo commented on PR #11508: URL: https://github.com/apache/tvm/pull/11508#issuecomment-1141883470
Thanks for your contribution for BYOC-DNNL. And my suggestions are listed below: 1. I wonder if we can get better performance via running `layernorm` on `dnnl codegen` than running consecutive ops on `native codegen`. Could you please provide some performance numbers? 2. `Lint` has failed. Please run `task_lint.sh` to check the code style. 3. `UT` is required. You can add your test cases in `tests/python/contrib/test_dnnl.py` to ensure the functionality of the enabled ops. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
