tkonolige commented on PR #11479:
URL: https://github.com/apache/tvm/pull/11479#issuecomment-1142558863

   @merrymercy as far as I can tell, feature extraction does not guarantee that 
feature vectors are the same length. Looking at 
`src/autotvm/touch_extractor.cc` 
https://github.com/apache/tvm/blob/main/src/autotvm/touch_extractor.cc#L335 the 
length of the the feature vector depends on the number of itervars in the 
program. If the schedule used applies a different number of splits based on 
some autotvm config, then the number of itervars will not be consistent.
   
   It seems that we have to add padding somewhere. We can either add it in the 
xgb tuner or in the feature extractor. If we add it to the feature extractor, 
then we need to guess the maximum number of itervars allowed which could either 
lead to lots of wasted space in the feature vector or failures when there are 
more itervars than expected. To me it seems easier to apply the fix in the 
tuner.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to