Lunderberg commented on PR #11327: URL: https://github.com/apache/tvm/pull/11327#issuecomment-1144166025
Thank you for the feedback on it @Mousius . I definitely see your point on having a consistent style, and that slow relaxation of linter rules converges on having no linter rules. I'd also agree about linter rules beings about individual coding style, but would include the tooling defaults in that category as set by the individual coding style of the linter's authors, and so there's a benefit in having project-specific settings. I think I'd still make a distinction between consistency that adds clarity and consistency that removes clarity. As a deliberately extreme example, a linter rule requiring all local variables to be single character in alphabetical order of first appearance would make the code much more consistent, at the expense of readability. While `no-else-return` is nowhere near as extreme as the hypothetical check, I initially proposed disabling the check because it felt to me that it was making a similar tradeoff, without enough consistency to warrant the decrease in readability. Overall, my preference would be to remove the check, but that the time spent on the discussion has outweighed the benefit from the change, so I'm okay with either outcome as a way of concluding the discussion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
