gigiblender commented on code in PR #11470: URL: https://github.com/apache/tvm/pull/11470#discussion_r888066187
########## docker/install/ubuntu_install_zephyr.sh: ########## @@ -38,10 +39,12 @@ sudo apt-key add kitware-archive-latest.asc echo deb https://apt.kitware.com/ubuntu/ bionic main\ >> /etc/apt/sources.list.d/kitware.list -sudo apt-get update +sudo apt-get update --fix-missing Review Comment: I am not sure if omitting `apt-update`s is possible. As far as I understand, performing an `apt-get install` will do a lookup in `/var/lib/apt/lists/` for the desired package (and the relevant dependencies). However, after each `apt-get install`, we clear that directory to reduce the docker layer size (resulting in a smaller image). Therefore, I think running `apt-get update` on each install is necessary in this case. I tried to implement the md5 sum check and it resulted in [packages not being located](https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-11470/7/pipeline/53). Also, the [best practices guide for docker files](https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#run) seems to suggest something similar with regards to running `apt-get update` and `apt-get install` in the same layer. Please let me know if you have other thoughts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
