mbs-octoml commented on code in PR #11474:
URL: https://github.com/apache/tvm/pull/11474#discussion_r888501461
##########
include/tvm/relay/function.h:
##########
@@ -170,19 +170,34 @@ const FunctionNode* AsOptimizableFunctionNode(const
BaseFunc& base_func);
* \brief namespace of the attributes that can be attached to a
relay::Function.
*/
namespace attr {
-/*! \brief Mark the function as a primitive function. */
+
+/*!
+ * \brief Mark the function as a primitive function. Should be bound to \p
Integer(1).
+ *
+ * Type: Integer
+ */
constexpr const char* kPrimitive = "Primitive";
+
+/*!
+ * \brief Mark the function as being 'extern', ie implemented in a
runtime::Module. Should be bound
Review Comment:
Ditto. Gave all these comments a refresh to reflect how things actually
work. (I've only tweaked the "Extern" attribute, others are unchanged in use
and semantics.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
