FranckQC commented on PR #11574: URL: https://github.com/apache/tvm/pull/11574#issuecomment-1146727345
The only item failing seems to be a flaky test to me as it's unrelated with the changes introduced by this PR: In the test file test_custom_datatypes.py, the function test_myfloat() gives: UserWarning: target_host parameter is going to be deprecated. Please pass in tvm.target.Target(target, host=target_host) instead. I reported the issue there: https://github.com/apache/tvm/issues/11580 Everything else seems ok to me. This PR is now ok to be reviewed :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
