elvin-n commented on code in PR #11543:
URL: https://github.com/apache/tvm/pull/11543#discussion_r891973295
##########
tests/python/relay/utils/adreno_utils.py:
##########
@@ -116,3 +117,14 @@ def gpu_preprocess(tvm_mod):
mod = tvm.IRModule.from_expr(tvm_mod)
tvm_mod_nchwc = seq(mod)
return tvm_mod_nchwc
+
+
+def gpu_preprocess_nhwc(tvm_mod):
Review Comment:
we do not use this func, right? is it artifact of some intermediate test
implementations?
Need to remove?
##########
src/runtime/texture.h:
##########
@@ -94,6 +94,25 @@ inline bool IsTextureStorage(std::string scope) {
return scope.find("texture") != std::string::npos;
}
+class TVM_DLL Pool {
Review Comment:
this class is declared under tvm::runtime namespace that means that is
visible and can be acceptable for anyone + gives impression that there is
something generic in context of the whole runtime while it is something special
for opencl textures only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
