zxybazh commented on code in PR #11486: URL: https://github.com/apache/tvm/pull/11486#discussion_r894127242
########## src/meta_schedule/profiler.cc: ########## @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +#include "./utils.h" + +namespace tvm { +namespace meta_schedule { + +/**************** Context Manager ****************/ + +struct ScopedTimer { + std::function<void()> func; + + explicit ScopedTimer(std::function<void()> func) : func(func) {} + ~ScopedTimer() { + LOG(INFO) << "destructed"; + func(); + } +}; Review Comment: Currently it's compilable with a forward declaration. I found it might cause compilation trouble if I put the definition in header file. Maybe we can keep it as it is? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
