adstraw commented on PR #11653: URL: https://github.com/apache/tvm/pull/11653#issuecomment-1152758033
Just realized that I named my commit "static cast for TVMStreamHandle` before I realized that reinterpret_cast was required. I can rename that commit or ... Just thinking out loud here ... the other thing we can do RE `TVMStreamHandle` is just remove it from this PR. It's there because we are looking ahead to working with actual stream handles at the Device API level. But, what we really need is just an `unsigned` thread ID. What's there is a bit of a misuse of a pointer type to stash an integer and probably over-engineered at least for the time being. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
