Mousius commented on code in PR #11666:
URL: https://github.com/apache/tvm/pull/11666#discussion_r895010447
##########
tests/python/ci/test_ci.py:
##########
@@ -49,7 +38,7 @@ def run(pr_body, requested_reviewers, existing_review_users,
expected_reviewers)
git.run("remote", "add", "origin", "https://github.com/apache/tvm.git";)
reviews = [{"user": {"login": r}} for r in existing_review_users]
requested_reviewers = [{"login": r} for r in requested_reviewers]
- proc = subprocess.run(
+ proc = subprocess.run( # pylint: disable=subprocess-run-check
Review Comment:
Looking at the `subprocess-run-check` linter rule, shouldn't we pass `check`
explicitly to resolve it?
##########
tests/python/ci/test_ci.py:
##########
@@ -342,9 +341,12 @@ def run(files, should_skip):
def test_ping_reviewers(tmpdir_factory):
+ """
+ Test that reviewers are messaged after a time period of inactivity
+ """
reviewers_script = REPO_ROOT / "tests" / "scripts" / "ping_reviewers.py"
- def run(pr, check):
+ def run(pr, check): # pylint: disable=invalid-name
Review Comment:
Wouldn't it be better to fix the function name than ignore the linter
warning?
##########
tests/python/ci/test_ci.py:
##########
@@ -703,27 +713,31 @@ def run(type, data, check):
)
run(
- type="ISSUE",
+ source_type="ISSUE",
data={
"title": "[something] A title",
"number": 1234,
"user": {
"login": "person5",
},
"labels": [{"name": "something2"}],
+ # pylint: disable=line-too-long
"body": textwrap.dedent(
"""
`mold` and `lld` can be a much faster alternative to `ld` from
gcc. We should modify our CMakeLists.txt to detect and use these when possible.
cc @person1
Review Comment:
Can we not have a line per sentence here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
