PhilippvK commented on PR #11702: URL: https://github.com/apache/tvm/pull/11702#issuecomment-1155129833
@ashutosh-arm AFAIK there currently exist no test for the `RelayToTIRVisitor` itself. The routine `AvgPoolBufferSize` is correctly implemented but never invoked due to a typo in the if-statement in `relay_to_tir.cc`. If we want to catch that sort of bug in the future, we need to write Tests for the individual `Emit*` functions. A test would probably have failed if `cortex-m33`(DSP only) instead of `cortex-m55` (MVEI+DSP) would have been used in integrations tests with CMSIS-NN (Assuming that an `avg_pool2d` is part of a used model). However I am not sure in which degree cmsisnn is currently involved in integration tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
