d-smirnov commented on code in PR #10189:
URL: https://github.com/apache/tvm/pull/10189#discussion_r897054217
##########
include/tvm/ir/memory_pools.h:
##########
@@ -130,15 +129,159 @@ static const int kUnknownReadBandwidth = -1;
static const int kUnknownWriteBandwidth = -1;
class PoolInfo : public ObjectRef {
- public:
- TVM_DLL PoolInfo(String pool_name, Map<Target, String> target_access,
- Integer size_hint_bytes = kUnrestrictedPoolSizeHint,
+ protected:
+ TVM_DLL PoolInfo(String pool_name, Integer size_hint_bytes =
kUnrestrictedPoolSizeHint,
Integer clock_frequency_hz = kUnknownClockFrequency,
Integer read_bandwidth_bytes_per_cycle =
kUnknownReadBandwidth,
Integer write_bandwidth_bytes_per_cycle =
kUnknownWriteBandwidth,
Integer read_latency_cycles = 0, Integer
write_latency_cycles = 0,
Map<Target, Integer> target_burst_bytes = {}, Bool
is_internal = Bool(false));
- TVM_DEFINE_MUTABLE_OBJECT_REF_METHODS(PoolInfo, ObjectRef, PoolInfoNode);
+
+ public:
+ // TVM_DEFINE_MUTABLE_OBJECT_REF_METHODS(PoolInfo, ObjectRef, PoolInfoNode);
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
