manupa-arm commented on code in PR #10189:
URL: https://github.com/apache/tvm/pull/10189#discussion_r897441710
##########
include/tvm/ir/memory_pools.h:
##########
@@ -130,15 +129,159 @@ static const int kUnknownReadBandwidth = -1;
static const int kUnknownWriteBandwidth = -1;
class PoolInfo : public ObjectRef {
- public:
- TVM_DLL PoolInfo(String pool_name, Map<Target, String> target_access,
- Integer size_hint_bytes = kUnrestrictedPoolSizeHint,
+ protected:
+ TVM_DLL PoolInfo(String pool_name, Integer size_hint_bytes =
kUnrestrictedPoolSizeHint,
Integer clock_frequency_hz = kUnknownClockFrequency,
Integer read_bandwidth_bytes_per_cycle =
kUnknownReadBandwidth,
Integer write_bandwidth_bytes_per_cycle =
kUnknownWriteBandwidth,
Integer read_latency_cycles = 0, Integer
write_latency_cycles = 0,
Map<Target, Integer> target_burst_bytes = {}, Bool
is_internal = Bool(false));
- TVM_DEFINE_MUTABLE_OBJECT_REF_METHODS(PoolInfo, ObjectRef, PoolInfoNode);
+
+ public:
+ // TVM_DEFINE_MUTABLE_OBJECT_REF_METHODS(PoolInfo, ObjectRef, PoolInfoNode);
+ TVM_DEFINE_OBJECT_REF_METHODS(PoolInfo, ObjectRef, PoolInfoNode);
+};
+
+/*!
+ * \brief Describes a pool of memory properties
+ */
+struct PoolInfoPropertiesNode : public Object {
+ /*! \brief The expected size hint to be used by the allocator.
+ * The size_hint_bytes is set to kUnrestrictedPoolSizeHint
+ * to indicate the pool is not size restricted.
+ */
+ Integer size_hint_bytes = kUnrestrictedPoolSizeHint;
+ /*! \brief The clock frequency of the memory in Hz */
+ Integer clock_frequency_hz = kUnknownClockFrequency;
+ /*! \brief The read bandwidth in bytes/cycle */
+ Integer read_bandwidth_bytes_per_cycle = kUnknownReadBandwidth;
+ /*! \brief The write bandwidth in bytes/cycle */
+ Integer write_bandwidth_bytes_per_cycle = kUnknownWriteBandwidth;
+ /*! \brief The read latency in cycles */
+ Integer read_latency_cycles = 0;
+ /*! \brief The write latency in cycles */
+ Integer write_latency_cycles = 0;
+ /*! \brief The burst length in bytes for each Target */
+ Map<Target, Integer> target_burst_bytes{};
+ /*! \brief Whether pool is internally generated.
+ * The internal pools will be generated as part of
+ * the entry point code generation of the executor
+ */
+ bool is_internal = false;
+
+ void VisitAttrs(tvm::AttrVisitor* v) {
+ v->Visit("size_hint_bytes", &size_hint_bytes);
+ v->Visit("clock_frequency_hz", &clock_frequency_hz);
+ v->Visit("read_bandwidth_bytes_per_cycle",
&read_bandwidth_bytes_per_cycle);
+ v->Visit("write_bandwidth_bytes_per_cycle",
&write_bandwidth_bytes_per_cycle);
+ v->Visit("read_latency_cycles", &read_latency_cycles);
+ v->Visit("write_latency_cycles", &write_latency_cycles);
+ v->Visit("target_burst_bytes", &target_burst_bytes);
+ v->Visit("is_internal", &is_internal);
+ }
+
+ bool SEqualReduce(const PoolInfoPropertiesNode* other, SEqualReducer equal)
const {
+ return equal(size_hint_bytes, other->size_hint_bytes) &&
+ equal(clock_frequency_hz, other->clock_frequency_hz) &&
+ equal(read_bandwidth_bytes_per_cycle,
other->read_bandwidth_bytes_per_cycle) &&
+ equal(write_bandwidth_bytes_per_cycle,
other->write_bandwidth_bytes_per_cycle) &&
+ equal(read_latency_cycles, other->read_latency_cycles) &&
+ equal(write_latency_cycles, other->write_latency_cycles) &&
+ equal(target_burst_bytes, other->target_burst_bytes) &&
+ equal(is_internal, other->is_internal);
+ }
+
+ void SHashReduce(SHashReducer hash_reduce) const {
+ hash_reduce(size_hint_bytes);
+ hash_reduce(clock_frequency_hz);
+ hash_reduce(read_bandwidth_bytes_per_cycle);
+ hash_reduce(write_bandwidth_bytes_per_cycle);
+ hash_reduce(read_latency_cycles);
+ hash_reduce(write_latency_cycles);
+ hash_reduce(target_burst_bytes);
+ hash_reduce(is_internal);
+ }
+
+ static constexpr const char* _type_key = "ir.PoolInfoProperties";
+ TVM_DECLARE_FINAL_OBJECT_INFO(PoolInfoPropertiesNode, Object);
+};
+
+class PoolInfoProperties : public ObjectRef {
+ public:
+ TVM_DLL PoolInfoProperties(Integer size_hint_bytes,
+ Integer clock_frequency_hz =
kUnknownClockFrequency,
+ Integer read_bandwidth_bytes_per_cycle =
kUnknownReadBandwidth,
+ Integer write_bandwidth_bytes_per_cycle =
kUnknownWriteBandwidth,
+ Integer read_latency_cycles = 0, Integer
write_latency_cycles = 0,
+ Map<Target, Integer> target_burst_bytes = {},
+ Bool is_internal = Bool(false));
+ TVM_DEFINE_MUTABLE_OBJECT_REF_METHODS(PoolInfoProperties, ObjectRef,
PoolInfoPropertiesNode);
+};
+
+struct WorkspacePoolInfoNode : public PoolInfoNode {
+ static constexpr const char* _type_key = "ir.WorkspacePoolInfo";
+ TVM_DECLARE_FINAL_OBJECT_INFO(WorkspacePoolInfoNode, PoolInfoNode);
+};
+
+class WorkspacePoolInfo : public PoolInfo {
Review Comment:
Feels a bit stylistic choice for me.
Also, it would be great to get "a" version of this as this PR is getting
conflicted.
If you feel strongly, we can consider a follow up maybe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
