Mousius commented on code in PR #11701:
URL: https://github.com/apache/tvm/pull/11701#discussion_r897722212
##########
python/tvm/relay/op/contrib/cmsisnn.py:
##########
@@ -206,17 +206,17 @@ def qnn_avg_pool2d_pattern():
def check_qnn_avg_pool2d(pattern):
"""Check if avg pool2d is supported by CMSIS-NN."""
output = pattern
- input_var = _find_last(pattern)
Review Comment:
We can remove the `_find_last` function now 😸
##########
tests/python/contrib/test_cmsisnn/test_pooling.py:
##########
@@ -45,11 +45,15 @@ def make_model(
zero_point=-33,
relu_type="RELU",
layout="NHWC",
+ input_op=None,
Review Comment:
I assume this is because we're creating an object and it doesn't like to use
that as a default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
