wrongtest commented on PR #11828: URL: https://github.com/apache/tvm/pull/11828#issuecomment-1163651679
> Hey thanks for the contribution! I don't think I fully comprehend this change (and the unittest) so would love to hear more about your insights :-) With this change, whether or not to add a `tir::Var` into `dom_map` is based on its dtype. Why is it the case? Emmmmm，my understand is that since the pass is only interested in buffer indices，record index typed vars could be safe. While arith utilities are written to handle integers，binding things like SinglePoint(int32x8) would just fail on sanity checks of dom analysis (eg, EvalNDSet). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
