leandron commented on PR #11852: URL: https://github.com/apache/tvm/pull/11852#issuecomment-1164618990
> I'm not sure what such a testcase should do. The main motivation for this change was to avoid the "reverse dependency" between .cc and .h files. The aren't any tests that I know of that are specific to the factory functions, but if you have any suggestions, let me know. Following the logic being introduced in this PR, I suppose tests could assert that two calls for the factory function will generate two different instances; another test could assert that an invalid target would return `nullptr`. Does that make sense? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
