jverma-quic commented on code in PR #11522: URL: https://github.com/apache/tvm/pull/11522#discussion_r905303666
########## tests/python/contrib/test_hexagon/topi/test_batch_flatten.py: ########## @@ -0,0 +1,101 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import numpy as np +import pytest + +import tvm +import tvm.testing +import tvm.topi.hexagon.slice_ops as sl +from tvm import te, topi +from tvm.contrib.hexagon.build import HexagonLauncher +from tvm.topi import testing + +from ..infrastructure import allocate_hexagon_array, transform_numpy + + +class BaseTestBatchFlatten: + input_shape = tvm.testing.parameter( + (1, 1, 1, 2048), + (1, 2, 4, 2048), + (1, 8, 8, 1024), + (2, 4, 8, 1024), + (2, 3, 5, 2048), + ) + input_layout, input_axis_sep = tvm.testing.parameters(("nhwc-1024c-1d", [4])) + output_layout, output_axis_sep = tvm.testing.parameters(("nc-1d", [2])) Review Comment: Please change "1d" to "2d" in the layout string. ########## tests/python/contrib/test_hexagon/infrastructure.py: ########## @@ -245,6 +245,12 @@ def transform_numpy(arr_np, current_layout: str, new_layout: str): n, h, w, c = arr_np.shape assert h == 1 and w == 1, "The size of h and w must be 1" return arr_np.reshape([n, 1, 1, c // 1024, 1024]) + if new_layout == "nc-1d": + N, C = arr_np.shape Review Comment: Same here. Should be nc_1024c_2d. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
