mbs-octoml commented on PR #11770: URL: https://github.com/apache/tvm/pull/11770#issuecomment-1167723426
Thanks @masahi & @areusch, PTAL. Re value_or: done, thanks, that's much nicer. Re split PRs, done. This was already a split of a split so sorry for the grab bag. Re end-to-end test: I think this should be done in test_target_hooks.py, but to really exercise everything requires a new fake JSON-based runtime module, a fake custom codegen pass and a new fake external codegen target. I started down that path but it will be quite a lift. Unfortunately however we can't rely on the tensorrt unit test for this (the first user of the new const_name_to_constants attribute) since the functionality won't be testable without running, which is not enabled in CI. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
