areusch commented on code in PR #11927: URL: https://github.com/apache/tvm/pull/11927#discussion_r908866851
########## ci/jenkins/README.md: ########## @@ -33,17 +37,20 @@ https://github.com/apache/tvm/actions has the logs for each of these workflows. ## Keeping CI Green -Developers rely on the TVM CI to get signal on their PRs before merging. -Occasionally breakages slip through and break `main`, which in turn causes -the same error to show up on an PR that is based on the broken commit(s). Broken -commits can be identified [through GitHub](https://github.com/apache/tvm/commits/main>) -via the commit status icon or via [Jenkins](https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/activity?branch=main>). -In these situations it is possible to either revert the offending commit or -submit a forward fix to address the issue. It is up to the committer and commit -author which option to choose, keeping in mind that a broken CI affects all TVM -developers and should be fixed as soon as possible. +Developers rely on the TVM CI to get signal on their PRs before merging. Occasionally breakages +slip through and break `main`, which in turn causes the same error to show up on an unrelated PR +that is based on the broken commit(s). Broken commits can be identified [through +GitHub](https://github.com/apache/tvm/commits/main>) via the commit status icon or via +[Jenkins](https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/activity?branch=main>). In these +situations it is possible to either revert the offending commit or submit a forward fix to address +the issue. It is up to the committer and commit author which option to choose. A broken CI affects +all TVM developers and should be fixed as soon as possible, while a revert may be especially painful +for the author of the offending PR when that PR is large. -Some tests are also flaky and fail for reasons unrelated to the PR. The [CI monitoring rotation](https://github.com/apache/tvm/wiki/CI-Monitoring-Runbook) watches for these failures and disables tests as necessary. It is the responsibility of those who wrote the test to ultimately fix and re-enable the test. +Some tests are also flaky and occasionally fail for reasons unrelated to the PR. The [CI monitoring +rotation](https://github.com/apache/tvm/wiki/CI-Monitoring-Runbook) watches for these failures and +disables tests as necessary. It is the responsibility of those who wrote the test to ultimately fix +and re-enable the test. ## Dealing with Flakiness Review Comment: oh whoops, this was pretty sloppy. done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
