driazati commented on code in PR #11969:
URL: https://github.com/apache/tvm/pull/11969#discussion_r911283290
##########
python/tvm/testing/utils.py:
##########
@@ -95,7 +95,8 @@ def test_something():
SKIP_SLOW_TESTS = os.getenv("SKIP_SLOW_TESTS", "").lower() in {"true", "1",
"yes"}
skip_if_wheel_test = pytest.mark.skipif(
- os.getenv("WHEEL_TEST") is not None, reason="Test not supported in wheel."
+ os.getenv("WHEEL_TEST") is not None and len(os.getenv("WHEEL_TEST")) != 0,
Review Comment:
can we check for a positive value here instead of just any string? (copied
the values from `SKIP_SLOW_TESTS` above)
```suggestion
os.getenv("WHEEL_TEST", "").lower() in {"true", "1", "yes"},
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
