junrushao1994 commented on code in PR #12016:
URL: https://github.com/apache/tvm/pull/12016#discussion_r915210031


##########
python/tvm/meta_schedule/apply_history_best.py:
##########
@@ -85,8 +86,11 @@ def query(
             Target Info
         dispatched : Optional[List[IRModule]]
             A list of low-level IRs that the high-level IR could potentially 
dispatch to
-        f_take_tuning_record : Callable[[TuningRecord], None] = None
+        f_take_tuning_record : Optional[Callable[[TuningRecord], None]] = None
             A callback function that takes a tuning record and does something 
with it
+        f_direct_dispatch : Optional[Callable[[IRModule], Optional[Schedule]]] 
= None

Review Comment:
   Let's return `Optional[IRModule]` instead of `Optional[Schedule]`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to