zxybazh commented on code in PR #12050:
URL: https://github.com/apache/tvm/pull/12050#discussion_r917559399


##########
docs/install/from_source.rst:
##########
@@ -323,7 +323,7 @@ like ``virtualenv``.
 
    .. code:: bash
 
-       pip3 install --user tornado psutil xgboost cloudpickle
+       pip3 install --user tornado psutil xgboost==1.5.0 cloudpickle

Review Comment:
   Thanks for the fix, note that we can allow any version of xgboost before 
1.6.0, we can allow a larger range.
   ```suggestion
          pip3 install --user tornado psutil  'xgboost<1.6.0' cloudpickle
   ```



##########
docs/install/from_source.rst:
##########
@@ -339,7 +339,7 @@ configuration. A workaround for this is to do the following 
commands:
 
         pip install scipy --no-use-pep517
 
-        pip install xgboost
+        pip install xgboost==1.5.0

Review Comment:
   Ditto.



##########
python/gen_requirements.py:
##########
@@ -277,7 +277,7 @@
     ("torch", None),
     ("torchvision", None),
     ("tornado", None),
-    ("xgboost", ">=1.1.0"),  # From PR #4953.
+    ("xgboost", "==1.5.0"),  # latest xgboost is not avaliable. Version 
mismatch will be fixed later.

Review Comment:
   Ditto, you may preserve th previous comments
   ```suggestion
       ("xgboost", "'>=1.1.0,<1.6.0'"),  # From PR #4953 & Issue #12009
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to