billishyahao commented on code in PR #11966:
URL: https://github.com/apache/tvm/pull/11966#discussion_r919551761


##########
tests/python/contrib/test_dnnl.py:
##########
@@ -94,6 +94,9 @@ def partition_for_dnnl(mod, params=None, alter_layout=True, 
prune_subgraphs=True
             )
             with tvm.transform.PassContext(opt_level=3):
                 mod = seq(mod)
+
+    mod = dnnl.rewrite_dense_bias_gelu_reshape_last(mod)

Review Comment:
   Hi Peskov, This pass _rewrite_dense_bias_gelu_reshape_last_ only matches the 
pattern "dense_bias_activation". If we are desired to put it after "AlterOp" 
pass, then I need to extend the capability of pass 
_rewrite_dense_bias_gelu_reshape_ .



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to