Ever-Kid commented on code in PR #11936:
URL: https://github.com/apache/tvm/pull/11936#discussion_r919598262
##########
python/tvm/topi/nn/conv2d.py:
##########
@@ -79,17 +81,21 @@ def conv2d(input, filter, strides, padding, dilation,
layout="NCHW", out_dtype=N
dilation: int or a list/tuple of two ints
dilation size, or [dilation_height, dilation_width]
- layout : str
+ data_layout : str
layout of data
+ kernel_layout : Optional[str]
+ layout of kernel. If unspecified, use default layout inferred from
data_layout. "OHWI" if
+ data_layout == "NCHW", "HWIO" if data_layout == "NHWC".
Review Comment:
A little bit confused to me, shouldn’t "OIHW" & "NCHW" a default pair? I can
also see this pattern at line 248.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
