Lunderberg commented on code in PR #11970:
URL: https://github.com/apache/tvm/pull/11970#discussion_r920066628
##########
src/arith/analyzer.cc:
##########
@@ -52,6 +53,7 @@ void Analyzer::Bind(const Var& var, const Range& range, bool
allow_override) {
this->Bind(var, range->min, allow_override);
} else {
this->const_int_bound.Bind(var, range, allow_override);
+ this->int_set.Update(var, range, allow_override);
Review Comment:
The call to `Analyzer::Bind` when the extent is 1 does pass the definition
down to all analyzers, including `int_set`. The else case additionally exposes
the ranges to analyzers that could make use of them.
Regarding the name of "Update" vs "Bind", I hadn't seen a difference between
`Update` and `Bind` functions in the other subanalyzers beyond the input
arguments. I've changed the names to be as consistent as I could see with the
others, with "Update" used when providing the analyzer with the same data
structure as is used internally, and "Bind" used when providing it with
something that must be converted to the internal data structure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
