octoJon commented on PR #12079: URL: https://github.com/apache/tvm/pull/12079#issuecomment-1183705384
> Pretty sure @octoJon just needs to subtract the two values to get the feature they want. Right, but the issue is that I can't compute log(A/B) --which is what I want -- from log(A)/log(B) -- which is what we have before Tristan's change. I will be able to get it from log2p(A/B), so I am good with this change. A different option would have been to change the logic lower down in the file to essentially replace all the occurrences of log(FLOPs) / log(bytes) with log(FLOPs) - log(bytes), but Tristan's version is simpler and makes it less likely that we'd screw up the interpolation when attempting to make that change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
