areusch commented on code in PR #12074:
URL: https://github.com/apache/tvm/pull/12074#discussion_r921707838
##########
apps/microtvm/arduino/template_project/microtvm_api_server.py:
##########
@@ -522,13 +522,13 @@ def close_transport(self):
self._serial = None
def read_transport(self, n, timeout_sec):
- # It's hard to set timeout_sec, so we just throw it away
- # TODO fix this
+ self._serial.timeout = timeout_sec
if self._serial is None:
raise server.TransportClosedError()
return self._serial.read(n)
def write_transport(self, data, timeout_sec):
+ self._serial.timeout = timeout_sec
Review Comment:
i think you should be setting write_timeout, right?
##########
python/tvm/micro/testing/evaluation.py:
##########
@@ -83,6 +83,7 @@ def create_aot_session(
params,
build_dir=Path(tempfile.mkdtemp()),
tune_logs=None,
+ timeout_override=None,
Review Comment:
nit: units e.g. timeout_sec_override
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
