junrushao1994 commented on code in PR #12048:
URL: https://github.com/apache/tvm/pull/12048#discussion_r924226829
##########
python/tvm/script/printer/doc.py:
##########
@@ -29,12 +34,63 @@ class Doc(Object):
class ExprDoc(Object):
"""Base class of all expression Docs"""
+ def attr_access(self, attr: str) -> "AttrAccessDoc":
Review Comment:
for `doc.attr`, shall we consider renaming `AttrAccessDocNode::attr` to
something else, e.g. `AttrAccessDocNode::name`.
for `doc.index`, shall we consider instead moving the logic to an overloaded
operator `[]` in C++, and `__getitem__` on python?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
