gromero commented on PR #12114:
URL: https://github.com/apache/tvm/pull/12114#issuecomment-1189599755
@guberti Thanks for the enhancement, I remember facing this issue sometimes
in my setup in the past. The changes LGTM (although already merged by @areusch
-- he merged right when I was about to finish the review lol, but no worries
since you tagged me 4 days ago so fair enough! heh). The only thing I think
that needs to get fixed on a follow-on PR are these two f-strings here:
```
diff --git a/apps/microtvm/arduino/template_project/microtvm_api_server.py
b/apps/microtvm/arduino/template_project/microtvm_api_server.py
index 053acefa3..047164eff 100644
--- a/apps/microtvm/arduino/template_project/microtvm_api_server.py
+++ b/apps/microtvm/arduino/template_project/microtvm_api_server.py
@@ -495,12 +495,12 @@ class Handler(server.ProjectAPIHandler):
# be caught.
except subprocess.TimeoutExpired:
_LOG.warning(
- "Upload attempt to port {port} timed out after
{self.FLASH_TIMEOUT_SEC} seconds"
+ f"Upload attempt to port {port} timed out after
{self.FLASH_TIMEOUT_SEC} seconds"
)
else:
raise RuntimeError(
- "Unable to flash Arduino board after
{self.FLASH_MAX_RETRIES} attempts"
+ f"Unable to flash Arduino board after
{self.FLASH_MAX_RETRIES} attempts"
)
def open_transport(self, options):
```
Cheers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
