cbalint13 commented on PR #12087:
URL: https://github.com/apache/tvm/pull/12087#issuecomment-1190026779
> thanks @MichaelJKlaiber I've given this a look over. I think it's
generally in the right direction, suggest a couple more comments and a few
minor changes here and there. overall though, the approach looks great. i'd
love it if we could explore integrating this further with tvmc since we are
registering a custom Target. happy to discuss further!
@areusch ,
IMHO, for consideration purpose:
- UMA with it's approach to bridge "out-of-tree" things/implementations
into TVM might have "looser" tie & offerings for tvmc. I would only second the
idea that tvmc's "exposing fixed CLI features" **must** relay when in reality
it only **may** reach what (full/partially) will ever be implemented (by UMA
consumers) on top of UMA bridge itself. And this **may** statement is valid
even if we register a full tvm legit custom ```target``` via UMA.
- I can imagine someone's only goal via UMA is to generate lowered "c"
code blobs and **period**, code that includes super-optimised (inc.
auto-tensorized) __asm(".word " 0xc0fefe) calls for very special ISA
extensions. I won't condition this PR to tvmc with **a must** however some
really obvious things probably **can be** exposed via tvmc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
