manupa-arm commented on code in PR #12087: URL: https://github.com/apache/tvm/pull/12087#discussion_r925689353
########## python/tvm/relay/backend/contrib/uma/_template/backend.py: ########## @@ -0,0 +1,53 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. Review Comment: Given the out-of-tree usecase of UMA, I personally feel this might be better suited as an apps/ example, where we showcase to a "user" how UMA could be used. WDYT ? Even if its a template (in which case, we should hold the template here, maybe ?), however it would be still good demonstrate how to use that template is used in a "user" flow. *user here means a out-of-tree dev that wants to attach accelerator codegen to TVM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
