junrushao1994 commented on code in PR #12111:
URL: https://github.com/apache/tvm/pull/12111#discussion_r931325552
##########
include/tvm/script/printer/doc.h:
##########
@@ -219,6 +292,7 @@ class IdDoc : public ExprDoc {
* \param name The name of identifier.
*/
explicit IdDoc(String name);
+ explicit IdDoc(std::nullptr_t) : ExprDoc(nullptr) {}
Review Comment:
Yeah this is a good idea to explicitly define constructor with
`std::nullptr_t` so that the compiler could distinguish between `nullptr ->
const char* -> String` and `nullptr -> ObjectPtr`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
