yelite commented on PR #12197: URL: https://github.com/apache/tvm/pull/12197#issuecomment-1197379128
I think it's reasonable to let 3rd party library to handle the highlighting. It will take non-trivial effort to implement highlight in the TVMScript printer by ourselves. This also applies to other nice-to-have features like code formatting. Users might want the printed TVMScript to be free from very long lines and we can use black to format the output. IMO all those extra dependencies should be optional and the `show` function should just fallback to plain printing if those dependencies are not installed and then emit a warning message. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
