SebastianBoblest commented on code in PR #12028:
URL: https://github.com/apache/tvm/pull/12028#discussion_r933045267
##########
tests/python/frontend/tensorflow/test_forward.py:
##########
@@ -498,7 +501,7 @@ def _test_convolution(
add_shapes_to_graph_def=True,
):
"""One iteration of convolution with given shapes and attributes"""
-
+ # pylint: disable=dangerous-default-value
Review Comment:
You have a mutable default argument here:
[def
_test_convolutio](https://github.com/apache/tvm/blob/45b2d39d8fce7a11a596d03c6b914aa47fc2f952/tests/python/frontend/tensorflow/test_forward.py#L495)
If you want to know why this is bad, look for example here:
https://florimond.dev/en/posts/2018/08/python-mutable-defaults-are-the-source-of-all-evil/
To resolve this issue change
deconv_output_shape=[] to deconv_output_shape=None
and add
deconv_output_shape = deconv_output_shape or []
add the start of the function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
